add Remotes for p5 and suggests for Rbitcoin#3
Open
njtierney wants to merge 1 commit into
Open
Conversation
Owner
|
Not sure about `p5` as a remote as I've extended the core of that to suit
our needs, so it's all copied in.
…On 30 Oct. 2017 11:53 am, "Nicholas Tierney" ***@***.***> wrote:
This adds a Remotes field in the DESCRIPTION which allows the user to
install the package, installing Sean Kross's p5 package. I also added a
Suggests for Rbitcoin, as this is used in the vignette.
Looking forward to using this, great job! :)
------------------------------
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
- add Remotes for p5 and suggests for Rbitcoin
File Changes
- *M* DESCRIPTION
<https://github.com/ropenscilabs/realtime/pull/3/files#diff-0> (7)
Patch Links:
- https://github.com/ropenscilabs/realtime/pull/3.patch
- https://github.com/ropenscilabs/realtime/pull/3.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJDpId47KMDqbw_bMatwASpmrkRvx2w7ks5sxSUVgaJpZM4QKkNu>
.
|
Collaborator
Author
|
OK sure thing, perhaps the |
Owner
|
Yeah, there's a good chance I've accidentally left some namespace prefix in
there but it *should* all be local (not reliant on the p5 package). I
recall seeing the same thing but time pressure and all... there's plenty to
clean up.
With the `p5` package installed also, it *should* work. Refer to the
vignettes for examples on the master branch, and Jeff's excellent
implementations are in his branch.
…On Mon, Oct 30, 2017 at 3:03 PM, Nicholas Tierney ***@***.***> wrote:
OK sure thing, perhaps the Imports: p5 line should be removed from the
DESCRIPTION? I couldn't install the package with devtools::install()
without the p5 library.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJDpIRztiqI5iSa9HyiGJEWyP24SZbSCks5sxVF-gaJpZM4QKkNu>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Remotes field in the DESCRIPTION which allows the user to install the package, installing Sean Kross's
p5package. I also added a Suggests forRbitcoin, as this is used in the vignette.Looking forward to using this, great job! :)